Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.84.0 release post #1451

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Dec 29, 2024

@Mark-Simulacrum
Copy link
Member Author

cc rust-lang/rust#133210 @lcnr @rust-lang/types -- I expanded/reworded a bit the stub you had started for new trait solver in coherence, would definitely appreciate review to make sure I didn't get the details too wrong :)

cc @joshtriplett @rust-lang/cargo for the section on MSRV-aware resolver, I sort of semi-randomly came up with recommendations and general prose but very happy to replace it if there's something better or actual recommendations the team wants to offer :)

cc @rust-lang/opsem for the strict provenance section -- I tried to find a balance between copying in the whole contents of the standard library docs and referencing them, very open to changes though.

@Mark-Simulacrum
Copy link
Member Author

cc @rust-lang/release as well...

@jieyouxu
Copy link
Member

cc @alex-semenyuk @traviscross for relnotes blog post (I am triagebot)

posts/2025-01-09-Rust-1.84.0.md Outdated Show resolved Hide resolved
posts/2025-01-09-Rust-1.84.0.md Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

@Mark-Simulacrum I already spent some effort on Strict Provenance release notes in rust-lang/rust#131996, did you see that? I thought that is the intended place for such text.

@joshtriplett
Copy link
Member

cc @epage

@Mark-Simulacrum
Copy link
Member Author

@Mark-Simulacrum I already spent some effort on Strict Provenance release notes in rust-lang/rust#131996, did you see that? I thought that is the intended place for such text.

Thanks, I had seen it previously but missed it when putting together the blog (just my bad). Copied that text in, it looks good to me, thanks for writing it up!


## What's in 1.84.0 stable

### Cargo can use toolchain version for library version selection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“A toolchain”? “The toolchain”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header isn't ideal IMO -- but I'm not sure adding an article will help. It's hard for me to succinctly describe what this feature is without using jargon (e.g., MSRV), especially since it's not on by default.

posts/2025-01-09-Rust-1.84.0.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member Author

OK, I think that incorporates the feedback I have clear solutions for. I'm still not super happy with the header for the MSRV section, but I don't have any better ideas than the tweak I applied just now.


### Strict provenance APIs

In Rust, [pointers are not simply an "integer" or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention that provenance is also a thing C, for the sake of completeness and openness?

Suggested change
In Rust, [pointers are not simply an "integer" or
In Rust, as well as in C[^n3005], [pointers are not simply an "integer" or

detect and diagnose pointer misuse.

For more details, see the standard library [documentation on provenance](https://doc.rust-lang.org/std/ptr/index.html#provenance).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[^n3005]: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3005.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.